prod: fix 전반적인 오류 수정 #299
prod: fix 전반적인 오류 수정 #299
Conversation
MOSU-293 feat: 쿠키 검증 api 구현
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jbh010204, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on general error corrections and minor feature enhancements across the application. My primary goal was to address several identified issues and improve system robustness and user experience. Key areas of change include refining S3 file handling to respect length constraints, ensuring proper tagging for event-related files, standardizing UI text for consistency, and introducing a new API for client-side cookie validation. Additionally, I've made a small but important adjustment to cookie security settings for development environments to streamline local testing workflows.
Highlights
- S3 Key and Filename Length Enforcement: I've implemented logic within the S3 service to ensure that generated S3 keys and sanitized filenames do not exceed their respective maximum length constraints (255 for S3 keys, 150 for filenames). This prevents potential issues with overly long paths.
- Event File Tagging Update: The event creation process now includes a step to update the S3 tag for uploaded event files. This ensures that temporary files are correctly marked as permanent, which is crucial for proper file lifecycle management.
- Standardized Lunch Option Text: I've standardized the text displayed for the 'no lunch' option in the exam application service and the
Lunchenum. It now consistently shows '도시락 X' (Lunch X) instead of '신청 안 함' (Not applied), improving clarity for users. - Cookie Validation API Implementation: A new API endpoint,
/auth/check-cookie, has been added. This endpoint allows clients to verify the validity of their authentication cookies, providing a robust mechanism for session management and token validation. - Development Cookie Security Adjustment: For development environments, I've adjusted the
secureflag for cookies fromtruetofalse. This change facilitates local testing and development by allowing cookies to be sent over non-HTTPS connections.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces several fixes and new features, including a constraint on S3 key length, a new API endpoint for cookie validation, and updates to how development cookies are handled. My review has identified a critical bug in the S3 file handling logic that causes file extensions to be dropped, which could lead to significant issues. I've also found areas with code duplication and inconsistent error handling in the TokenFilter, which should be refactored to improve maintainability. Additionally, there's a minor syntax issue in AuthController.
| encoded = encoded.substring(0, MAX_FILENAME_LENGTH); | ||
| } | ||
|
|
||
| return encoded; |
There was a problem hiding this comment.
The sanitizeFileName method incorrectly drops the file extension. The extension is extracted from the encoded filename but is never appended back to the result. This will cause all uploaded files to lose their extensions. The comment on line 125, "파일명만 잘라내기 (확장자 유지)" (Cut out filename only (preserve extension)), indicates the intention was to preserve the extension.
| return encoded; | |
| return encoded + extension; |
| if (requestUri.startsWith(AuthConstants.COOKIE_ACCESS)) { | ||
|
|
||
| final TokenCookies tokenCookies = tokenResolver.resolveTokens(request); | ||
| String accessToken = tokenCookies.getAccessToken().orElseThrow( | ||
| () -> new CustomRuntimeException(ErrorCode.COOKIE_NOT_FOUND) | ||
| ); | ||
| try { | ||
| setAuthentication(accessToken); | ||
|
|
||
| response.setStatus(HttpServletResponse.SC_NO_CONTENT); | ||
| return; | ||
| } catch (CustomRuntimeException e) { | ||
| log.warn("쿠키 토큰 검증 실패: {}", e.getMessage()); | ||
| throw e; | ||
| } catch (Exception e) { | ||
| log.error("쿠키 토큰 검증 중 예외 발생", e); | ||
| throw new CustomRuntimeException(ErrorCode.INVALID_TOKEN); | ||
| } | ||
| } |
There was a problem hiding this comment.
There is significant code duplication between this new block for handling AuthConstants.COOKIE_ACCESS and the existing token validation logic that follows (lines 101-114). Both blocks resolve tokens, get the access token, and call setAuthentication within a try-catch block.
This duplication makes the code harder to maintain. For example:
tokenResolver.resolveTokens(request)is called twice.- The exception handling logic is similar but inconsistent. The new block re-throws
CustomRuntimeExceptionwhile the subsequent block wraps it. The logging levels and messages also differ.
Consider refactoring to a single token validation flow that handles both cases to improve readability and maintainability.
| return ResponseEntity.ok().build(); | ||
| } | ||
|
|
||
| ; |
There was a problem hiding this comment.
There is a stray semicolon here that is unnecessary and should be removed.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타