prod: 신청 시 추천인 검증 개선 #318
prod: 신청 시 추천인 검증 개선 #318
Conversation
MOSU-292 refactor: 추천인 검증 시 결제 완료 검증
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jbh010204, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the recommender verification process by introducing a new requirement: a user's recommender is now only considered verified if the user has successfully completed a payment for an exam application. This change aims to ensure that recommender benefits are tied to active, paying users. Additionally, a new query was added to support this verification, and a minor adjustment was made to an existing payment query.
Highlights
- Recommender Verification Logic Update: The 'verifyRecommender' method in 'RecommenderService' has been updated to require not only the presence of a recommender phone number but also a successful payment for an exam application by the user.
- New Payment Status Check: A new method, 'existsPaymentDoneByUserId', was introduced in 'ExamApplicationJpaRepository' to efficiently determine if a user has completed an exam application payment, which is crucial for the updated recommender verification.
- Recommender Registration Flexibility: The 'registerRecommender' method no longer throws an error if a recommender phone number is already registered, allowing for potential updates or re-registrations.
- Payment Query Adjustment: The 'findExamAndPaymentByExamApplicationId' query in 'ExamApplicationJpaRepository' was modified to remove the 'p.deleted = false' condition, which might affect how logically deleted payments are retrieved in that specific context.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
이번 PR은 신청 시 추천인 검증 로직을 개선하는 변경 사항을 포함하고 있습니다. RecommenderService에서 추천인 등록 로직이 변경되어 기존에 등록된 추천인을 수정할 수 있게 되었고, 추천인 검증 시 결제 완료 여부까지 확인하도록 강화되었습니다. ExamApplicationJpaRepository에는 결제 완료 여부를 확인하는 새로운 쿼리가 추가되었습니다.
코드 리뷰 결과, 몇 가지 개선점을 발견했습니다. RecommenderService의 검증 로직을 더 간결하게 수정할 수 있는 부분을 제안했습니다. 또한, ExamApplicationJpaRepository에서 쿼리의 일관성이 부족한 부분을 발견하여 수정 제안을 드렸습니다. 이는 잠재적인 버그를 방지하기 위한 중요한 수정입니다. 자세한 내용은 각 파일의 주석을 참고해주세요.
| JOIN ExamJpaEntity e ON ea.examId = e.id | ||
| JOIN PaymentJpaEntity p ON p.examApplicationId = ea.id | ||
| WHERE ea.id = :examApplicationId | ||
| AND p.paymentStatus = 'DONE' |
There was a problem hiding this comment.
findExamInfoWithExamNumber 쿼리에서 p.deleted = false 조건이 누락되었습니다. 이 리포지토리의 다른 쿼리들(새로 추가된 existsPaymentDoneByUserId 포함)에서는 소프트 삭제된 데이터를 필터링하기 위해 deleted = false 조건을 명시적으로 사용하고 있습니다. 일관성을 유지하고 잠재적인 버그(삭제된 결제 정보가 조회되는 문제)를 방지하기 위해 이 조건을 추가하는 것을 권장합니다.
AND p.paymentStatus = 'DONE'
AND p.deleted = false| if (profile.getRecommenderPhoneNumber() == null) { | ||
| return false; | ||
| } | ||
|
|
||
| return examApplicationJpaRepository.existsPaymentDoneByUserId(userId); |
There was a problem hiding this comment.
verifyRecommender 메서드의 로직을 더 간결하게 개선할 수 있습니다. if 문을 사용하는 대신, 논리 AND(&&) 연산자를 사용하여 한 줄로 표현하면 가독성이 향상됩니다.
return profile.getRecommenderPhoneNumber() != null && examApplicationJpaRepository.existsPaymentDoneByUserId(userId);
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타