feat: format phone number in user info synchronization #332
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @polyglot-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 PR은 사용자 정보 동기화 시 전화번호를 표준 형식으로 자동 포맷하는 기능을 추가합니다. 이는 ProfileService 내에서 PhoneNumberUtil을 사용하여 전화번호 데이터의 일관성을 보장합니다.
Highlights
- 유틸리티 임포트: ProfileService.java 파일에 life.mosu.mosuserver.global.util.PhoneNumberUtil 임포트가 추가되었습니다.
- 전화번호 포맷팅 적용: ProfileService의 syncUserInfoFromProfile 메서드 내에서 사용자 정보를 업데이트할 때, request.phoneNumber() 값이 PhoneNumberUtil.formatPhoneNumber() 메서드를 통해 포맷되도록 변경되었습니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds phone number formatting when synchronizing user information. The change correctly uses a utility to format the number before updating the user entity. However, I've identified a potential issue with data consistency. The phone number from the request may contain hyphens, and it's better to store it in a normalized form (without hyphens). My review includes a suggestion to remove hyphens before storage. I also noted that a similar change might be needed for the ProfileJpaEntity to maintain consistency across different tables.
| if (user.isMosuUser()) { | ||
| user.updateUserInfo(Gender.fromName(request.gender()), request.userName(), | ||
| request.phoneNumber(), request.birth()); | ||
| PhoneNumberUtil.formatPhoneNumber(request.phoneNumber()), request.birth()); |
There was a problem hiding this comment.
The phone number from SignUpProfileRequest might contain hyphens (e.g., "010-1234-5678"). Storing phone numbers with optional hyphens can lead to data inconsistency. It's best practice to normalize the phone number by removing hyphens before storing it. This ensures a canonical format in the database for UserJpaEntity.
Note: This change will make the phone number format in UserJpaEntity inconsistent with ProfileJpaEntity, as ProfileJpaEntity is created using request.toEntity() which uses the raw phone number. You should consider normalizing the phone number for ProfileJpaEntity as well for data consistency across the system, perhaps by modifying SignUpProfileRequest.toEntity().
| PhoneNumberUtil.formatPhoneNumber(request.phoneNumber()), request.birth()); | |
| PhoneNumberUtil.formatPhoneNumber(request.phoneNumber().replaceAll("-", "")), request.birth()); |
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타