[배포] 가상 쓰레드 활성화 및 버그 수정 #357

wlgns12370 · 2025-08-22T17:45:26Z

✨ 구현한 기능

프로필 등록한 카카오 중복 유저 업데이트]
가상 쓰레드 활성화

MOSU-354 feat: 가상 쓰레드 활성화

coderabbitai · 2025-08-22T17:45:32Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gemini-code-assist

Summary of Changes

Hello @wlgns12370, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 Spring 애플리케이션에서 가상 스레드를 활성화하고, 프로필 등록 시 발생하는 Kakao 중복 사용자 관련 버그를 수정하는 것을 목표로 합니다. 이를 통해 시스템의 동시성 처리 능력을 향상시키고, 사용자 등록 과정에서 발생하는 특정 오류를 보다 정확하게 처리할 수 있게 됩니다.

Highlights

가상 스레드 활성화: Spring 애플리케이션 설정에 가상 스레드를 활성화하는 설정을 추가했습니다.
Kakao 중복 사용자 처리 개선: 사용자 등록 프로세스를 수정하여 중복된 Kakao 사용자를 특별히 처리하고, USER_ALREADY_EXISTS 대신 KAKAO_DUPLICATED 예외를 발생시킵니다.
사용자 엔티티 헬퍼 메서드 추가: UserJpaEntity에 isKakaoUser()라는 새로운 헬퍼 메서드를 추가하여 코드의 가독성을 높였습니다.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

이번 PR은 가상 쓰레드를 활성화하고 카카오 중복 가입자 처리 로직을 개선하는 변경 사항을 포함하고 있습니다. 전반적으로 좋은 방향의 수정이지만, 몇 가지 개선점을 제안합니다.

가입 로직에서 중복된 조건을 제거하여 코드를 더 간결하게 만들 수 있습니다. 또한, 가상 쓰레드 활성화와 관련하여 기존의 쓰레드 풀 설정(ThreadPoolConfig)이 비동기 작업에 미치는 영향에 대한 검토가 필요해 보입니다. 자세한 내용은 각 파일에 남긴 코멘트를 참고해주세요.

gemini-code-assist · 2025-08-22T17:46:48Z

src/main/resources/application-base.yml

+  threads:
+    virtual:
+      enabled: true


가상 쓰레드를 활성화하면 Spring Boot는 웹 요청을 처리하기 위해 가상 쓰레드를 사용하게 됩니다. 이는 좋은 변화입니다.

하지만, 프로젝트 내에 ThreadPoolConfig가 별도로 설정되어 있어 @Async 어노테이션을 사용하는 비동기 작업들은 계속해서 기존의 플랫폼 쓰레드 풀을 사용하게 됩니다. 만약 비동기 작업에도 가상 쓰레드를 적용하고자 하신다면 ThreadPoolConfig 설정을 제거하거나 가상 쓰레드를 사용하도록 수정하는 것을 고려해 보시는 것이 좋습니다.

Spring Boot 3.2 이상에서는 spring.threads.virtual.enabled=true 설정 시, 별도의 TaskExecutor 빈이 없으면 @Async 작업에 자동으로 가상 쓰레드를 사용합니다. 현재 구성은 이 기본 동작을 재정의하고 있습니다. 의도된 동작이 아니라면 수정이 필요해 보입니다.

gemini-code-assist · 2025-08-22T17:46:48Z

src/main/java/life/mosu/mosuserver/application/auth/processor/SignUpAccountStepProcessor.java

+                    if (existingUser.isKakaoUser()) {
+                        throw new CustomRuntimeException(ErrorCode.KAKAO_DUPLICATED);
+                    } else if (existingUser.isPendingUser() && existingUser.isMosuUser()) {
+                        throw new CustomRuntimeException(ErrorCode.USER_ALREADY_EXISTS);
                    }


현재 로직에서 !existingUser.isKakaoUser()는 existingUser.isMosuUser()와 동일한 의미를 가집니다. (AuthProvider가 KAKAO와 MOSU 두 가지만 있기 때문입니다.) 따라서 else if 문에서 isMosuUser() 확인은 중복되므로 제거하여 코드를 더 간결하게 만들 수 있습니다.

Suggested change

if (existingUser.isKakaoUser()) {

throw new CustomRuntimeException(ErrorCode.KAKAO_DUPLICATED);

} else if (existingUser.isPendingUser() && existingUser.isMosuUser()) {

throw new CustomRuntimeException(ErrorCode.USER_ALREADY_EXISTS);

}

if (existingUser.isKakaoUser()) {

throw new CustomRuntimeException(ErrorCode.KAKAO_DUPLICATED);

} else if (existingUser.isPendingUser()) {

throw new CustomRuntimeException(ErrorCode.USER_ALREADY_EXISTS);

}

wlgns12370 and others added 3 commits August 23, 2025 00:30

MOSU-354 feat: 가상 쓰레드 활성화

2d536c3

MOSU fix: 프로필 등록한 카카오 중복 유저 업데이트

fd25476

Merge pull request #355 from mosu-dev/perf/mosu-354

62e79c0

MOSU-354 feat: 가상 쓰레드 활성화

gemini-code-assist bot reviewed Aug 22, 2025

View reviewed changes

wlgns12370 merged commit 9d98916 into prod Aug 22, 2025
4 of 5 checks passed

gemini-code-assist bot reviewed Aug 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[배포] 가상 쓰레드 활성화 및 버그 수정 #357

[배포] 가상 쓰레드 활성화 및 버그 수정 #357

Uh oh!

wlgns12370 commented Aug 22, 2025

Uh oh!

coderabbitai bot commented Aug 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 22, 2025

Uh oh!

gemini-code-assist bot Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[배포] 가상 쓰레드 활성화 및 버그 수정 #357

[배포] 가상 쓰레드 활성화 및 버그 수정 #357

Uh oh!

Conversation

wlgns12370 commented Aug 22, 2025

✨ 구현한 기능

Uh oh!

coderabbitai bot commented Aug 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)