-
Notifications
You must be signed in to change notification settings - Fork 1
MOSU-33 feature: 토스 페이먼츠 결제 흐름 구현 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 위한 설정 및 오류 처리 구현
… 결제 취소 및 확인 응답 처리 구현
… 및 결제 페이로드 데이터 전송을 위한 DTO 구현
…elFakeRestOperationsStub 클래스 추가 - 결제 확인 및 취소 요청을 위한 스텁 구현
…o feature/mosu-33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates Toss Payments by adding client configurations, stubs for testing, domain models, and supporting DTOs and controllers.
- Introduce
TossPaymentClient, error handler, and RestTemplate configuration for basic-auth calls. - Add test stubs (
ConfirmFakeRestOperationsStub,CancelFakeRestOperationsStub) and unit tests for payment confirmation. - Extend domain entities (
PaymentJpaEntity,PaymentAmountVO, enums) to persist payment details.
Reviewed Changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| CancelFakeRestOperationsStub.java | Stub incorrectly handles /confirm instead of /cancel |
| PaymentJpaEntity.java | Added quantity field but omitted in constructor/builder and of method |
| PaymentMethod.java | Leading space in card name literal |
| TossPaymentErrorHandler.java | Error handler throws generic RuntimeException without context |
src/test/java/life/mosu/mosuserver/payment/stub/CancelFakeRestOperationsStub.java
Outdated
Show resolved
Hide resolved
src/main/java/life/mosu/mosuserver/domain/payment/PaymentMethod.java
Outdated
Show resolved
Hide resolved
src/main/java/life/mosu/mosuserver/infra/payment/TossPaymentErrorHandler.java
Show resolved
Hide resolved
wlgns12370
reviewed
Jul 3, 2025
src/main/java/life/mosu/mosuserver/application/payment/PaymentService.java
Outdated
Show resolved
Hide resolved
src/main/java/life/mosu/mosuserver/domain/discount/DiscountPolicy.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 연결된 이슈
✨ 구현한 기능
🎸 기타