Feat/test: application 및 infra 단위 테스트 진행 #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd improve method formatting
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Warning Rate limit exceeded@polyglot-k has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 43 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (85)
WalkthroughRenamed CI job and split build/test steps with artifact upload. Added ApplicationContext.of factory method and fixed a validator package/import. Deleted EventAttachmentService. Removed a few trivial tests and added extensive new unit tests across application, inquiry, notice, payment, refund, infra, and repository layers. Introduced comprehensive test resources, Flyway migrations, and Redis Lua scripts. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client as Caller
participant ACtx as ApplicationContext
participant Repos as Repositories
Note over Client,ACtx: Assemble application responses
Client->>ACtx: of(applications, examApplications)
activate ACtx
ACtx->>Repos: fetchExams(examIds)
Repos-->>ACtx: exams
ACtx->>Repos: fetchSubjects(examAppIds)
Repos-->>ACtx: subjects
ACtx->>Repos: fetchPayments(examAppIds)
Repos-->>ACtx: payments
ACtx->>Repos: fetchRefunds(examAppIds)
Repos-->>ACtx: refunds
ACtx-->>Client: assemble() -> List<ApplicationResponse>
deactivate ACtx
note right of ACtx: New factory method ACtx.of(...)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jbh010204, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 Pull Request는 CI/CD 워크플로우를 개선하고, 문의 관련 기능에 대한 테스트 커버리지를 대폭 확장하는 것을 목표로 합니다. 빌드 및 테스트 프로세스를 분리하여 효율성을 높이고, 문의 답변 및 첨부 파일 서비스, 그리고 문의 컨트롤러에 대한 광범위한 테스트를 추가하여 시스템의 신뢰성과 유지보수성을 향상시킵니다. 또한, 전반적인 테스트 코드 정리와 함께 새로운 환경별 설정 및 데이터베이스 마이그레이션 스크립트를 도입하여 개발 및 배포 환경을 더욱 견고하게 만듭니다.
Highlights
- CI 워크플로우 개선: CI 워크플로우를 리팩토링하여 빌드 및 테스트 프로세스를 분리하고, 아티팩트 처리 효율성을 높였습니다. 이는 파이프라인의 명확성과 효율성을 크게 향상시킵니다.
- 문의 답변 서비스 테스트 강화: 문의 답변 서비스에 대한 포괄적인 단위 및 컨트롤러 테스트가 추가되어, 생성, 업데이트, 삭제, 조회 기능의 신뢰성과 오류 처리 능력이 강화되었습니다.
- 문의 첨부 파일 서비스 테스트 추가: 문의 첨부 파일 서비스에 대한 테스트가 추가되어, 파일 생성, 삭제, 업데이트 및 응답 변환 로직이 올바르게 작동하는지 검증합니다.
- 문의 컨트롤러 테스트 도입: 문의 컨트롤러에 대한 테스트가 추가되어, 문의 생성, 업데이트, 삭제, 상세 조회 및 사용자 문의 목록 엔드포인트의 동작이 검증됩니다.
- 테스트 코드 정리: 기존의 불필요하거나 중복되는 테스트 파일들이 제거되어 프로젝트의 테스트 코드베이스가 정리되었습니다.
- 광범위한 테스트 커버리지 확장: 애플리케이션 및 인프라 전반에 걸쳐 다양한 새로운 단위 및 통합 테스트 파일이 추가되어 전반적인 코드 품질과 안정성이 향상되었습니다.
- 환경별 설정 및 프로필 도입: Spring 프로필을 활용한 새로운 환경별 설정 파일들이 추가되었고, 기존
application.yml이 프로필 기반으로 변경되어 환경 관리가 더욱 유연해졌습니다. - 데이터베이스 마이그레이션 도입: 데이터베이스 초기화 및 데이터 삽입을 위한 Flyway 마이그레이션 스크립트가 추가되어 데이터베이스 버전 관리가 용이해졌습니다.
- Redis 할당량 관리 로직 추가: Redis 기반의 시험 할당량 관리를 위한 Lua 스크립트가 추가되어 동시성 제어 및 성능이 개선되었습니다.
- 보안 설정 강화: 카카오 OAuth 스코프가 확장되고 PBKDF2 암호화, 로그인 시도 제한, Rate Limit 등 보안 관련 설정이 강화되었습니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
src/test/java/life/mosu/mosuserver/application/inquiry/InquiryAnswerServiceTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Code Review
이번 PR은 CI 워크플로우 개선과 테스트 커버리지 향상에 큰 기여를 했습니다. 특히 다양한 서비스와 인프라에 대한 단위 테스트를 추가하여 코드의 신뢰성과 유지보수성을 높인 점이 인상적입니다.
다만, 몇 가지 개선점을 제안합니다.
backup디렉토리가 실수로 추가된 것으로 보입니다. 이 디렉토리에는 중복되거나 오래된 테스트 파일이 포함되어 있어 혼란을 줄 수 있으므로 제거하는 것이 좋겠습니다. 특히InquiryControllerTest2.java파일은 올바른 테스트 소스 경로로 이동해야 할 것 같습니다.- 일부 테스트에서
Mockito.mockConstruction을 사용하는 부분이 있는데, 이는 테스트를 복잡하게 만들 수 있습니다. 팩토리 패턴을 도입하여 의존성을 주입하면 테스트가 더 간결해질 것입니다. - 테스트 파일명에 오타가 있고, 여러 테스트에서 예외 처리를
e.printStackTrace()로 하고 있어 디버깅을 어렵게 할 수 있는 부분이 있습니다.
자세한 내용은 각 파일에 남긴 리뷰 코멘트를 참고해 주세요. 전반적으로 훌륭한 기여에 감사드립니다.
...life/mosu/mosuserver/application/application/processor/GetApplicationsStepProcessorTest.java
Show resolved
Hide resolved
...st/java/life/mosu/mosuserver/application/application/vaildator/ApplicationValidatorTest.java
Show resolved
Hide resolved
src/test/java/life/mosu/mosuserver/application/inquiry/InquiryAnswerServiceTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to both the CI workflow and the test coverage for inquiry-related features. The workflow is refactored to separate build and test jobs and to handle build artifacts more efficiently. Additionally, comprehensive unit and controller tests are added for inquiry answer and attachment services, as well as for the inquiry controller, improving reliability and maintainability.
CI Workflow Improvements
.github/workflows/docker-pr-build.yamlto split the build and test processes into separate jobs, added artifact upload/download steps, and changed the build step to skip tests. This improves pipeline efficiency and clarity. [1] [2]Test Coverage Enhancements
Inquiry Answer Service Tests
InquiryAnswerServiceTest.javawith thorough tests for creating, updating, deleting, and retrieving inquiry answers, including edge cases for error handling.Inquiry Attachment Service Tests
InquiryAttachmentServiceTest.javato test creation, deletion, updating, and response conversion for inquiry attachments, ensuring correct repository and S3 interactions.Inquiry Controller Tests
InquiryControllerTest2.javato test inquiry creation, update, deletion, detail retrieval, and user inquiry list endpoints, validating controller behavior and response structure.Summary by CodeRabbit