-
Notifications
You must be signed in to change notification settings - Fork 1
prod #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
prod #376
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c0fea09
MOSU docs: 코드 안정성 md 파일 추가
wlgns12370 12c3c82
fix: 신청 실패 로그 Duration 48시간으로 증가
jbh010204 c4202b9
fix: batchJob 임시 중지
polyglot-k 3f3aa3a
Merge branch 'develop' of https://github.com/mosu-dev/mosu-server int…
polyglot-k e7f5d98
feat: add endpoint to retrieve paid application count by school
polyglot-k 59ba93d
feat: add endpoint to retrieve paid application count by school
polyglot-k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| --- | ||
| name: 코드 안정성 | ||
| about: 코드 안정성 대한 요청 | ||
| title: "[🛠 코드 안정성] " | ||
| labels: 코드 안정성 | ||
| assignees: "" | ||
| --- | ||
|
|
||
| ## ✨ 문제 요약 | ||
|
|
||
| 현재 발생한 문제나 개선이 필요한 부분에 대해 한 줄로 명확하게 요약해주세요. | ||
|
|
||
| ---- | ||
|
|
||
| - | ||
|
|
||
| ## 🐛 어떤 문제가 발생했나요? | ||
|
|
||
| 자세한 문제 상황을 설명해주세요. 버그, 성능 저하, 코드의 문제점(Code Smell) 등 어떤 종류의 안정성 문제인지 구체적으로 서술합니다. | ||
|
|
||
| ---- | ||
|
|
||
| - | ||
|
|
||
| ## 🕹️ 어떻게 재현할 수 있나요? | ||
|
|
||
| 문제를 재현할 수 있는 구체적인 순서를 단계별로 작성해주세요. | ||
| 만약 재현이 어렵다면, 어떤 상황에서 주로 발생하는지 설명해주세요. (ex. 특정 API에 요청이 몰릴 때) | ||
|
|
||
| ---- | ||
|
|
||
| 1. `이 단계에서는...` | ||
| 2. `그 다음에는...` | ||
| 3. `그러면 문제가 발생합니다.` | ||
|
|
||
| ## 🤔 기대 결과와 실제 결과는 무엇이었나요? | ||
|
|
||
| - **기대 결과**: 원래라면 어떻게 동작해야 했는지 설명해주세요. | ||
| - **실제 결과**: 실제로 어떻게 동작했는지, 어떤 오류가 발생했는지 설명해주세요. | ||
|
|
||
| ---- | ||
|
|
||
| - **기대 결과**: | ||
| - **실제 결과**: | ||
|
|
||
| ## 📎 근거 자료 | ||
|
|
||
| 문제 상황을 파악하는 데 도움이 되는 모든 자료를 첨부해주세요. | ||
|
|
||
| - **에러 로그**: `(에러 로그를 여기에 붙여넣어 주세요)` | ||
| - **스크린샷**: `(스크린샷 이미지 첨부)` | ||
| - **관련 코드**: 문제가 발생한 코드의 일부 또는 파일 경로 | ||
|
|
||
| ---- | ||
|
|
||
| - | ||
|
|
||
| ## 📝 추가 사항 | ||
|
|
||
| 이슈 해결에 도움이 될 만한 추가 정보나 고려해야 할 조건이 있다면 자유롭게 기입해주세요. | ||
|
|
||
| ---- | ||
|
|
||
| - | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...ava/life/mosu/mosuserver/presentation/application/dto/SchoolApplicationCountResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package life.mosu.mosuserver.presentation.application.dto; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
|
|
||
| @Schema(description = "학교별 결제된 신청 수 응답") | ||
| public record SchoolApplicationCountResponse( | ||
| @Schema(description = "학교명", example = "서울고등학교") | ||
| String schoolName, | ||
|
|
||
| @Schema(description = "결제된 신청 수", example = "25") | ||
| Long paidApplicationCount | ||
| ) { | ||
| } |
85 changes: 0 additions & 85 deletions
85
src/test/java/life/mosu/mosuserver/infra/cron/job/LogCleanupJobTest.java
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
템플릿 설명에 사소한 오타가 있습니다. '코드 안정성 대한 요청'을 '코드 안정성에 대한 요청'으로 수정하여 문법적으로 더 자연스럽게 만들 수 있습니다.