-
Notifications
You must be signed in to change notification settings - Fork 1
prod #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prod #380
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @polyglot-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 풀 리퀘스트는 Redis 관련 설정 개선과 학교별 지원자 수 집계 로직의 정확성 향상에 중점을 둡니다. 불필요한 Redis Reactive 종속성을 제거하고 Redis 연결을 명시적으로 구성하여 안정성을 높이며, 학교 정보 출처를 사용자 프로필로 변경하여 데이터 일관성을 확보합니다.
Highlights
- Redis Reactive 종속성 제거:
build.gradle파일에서spring-boot-starter-data-redis-reactive종속성이 제거되었습니다. - Redis 연결 팩토리 명시적 구성:
RedisConfig.java에LettuceConnectionFactory를 명시적으로 구성하는@Bean메서드가 추가되어 Redis 연결 설정이 더욱 세밀하게 제어됩니다. - 학교별 지원자 수 조회 쿼리 수정:
ApplicationJpaRepository.java에서 학교별 지원자 수를 조회하는 JPA 쿼리가ExamJpaEntity대신ProfileJpaEntity의 학교 정보를 사용하도록 업데이트되었습니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 Redis 설정을 명시적으로 변경하고, 학교별 신청 수를 집계하는 쿼리를 수정합니다. Redis 설정은 스프링 부트 자동 설정을 활용하여 더 간결하고 유연하게 만들 수 있습니다. 한편, 학교별 신청 수 집계 쿼리는 집계 기준이 시험 장소에서 신청자 소속 학교로 변경되어 통계 결과가 달라질 수 있습니다. 이 변경이 비즈니스 요구사항에 부합하지 않을 경우 잘못된 데이터를 제공할 위험이 있습니다.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타