-
Notifications
You must be signed in to change notification settings - Fork 1
perf: GC max pause 시간 100ms로 설정 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MOSU-395 perf: GC max pause 시간 100ms로 설정
Summary of ChangesHello @wlgns12370, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the Dockerfile to configure the garbage collection (GC) settings for the Java application. Specifically, it sets the maximum GC pause time to 100ms and includes other JVM arguments to optimize memory usage and GC behavior. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이번 PR은 Dockerfile의 ENTRYPOINT에 JVM 옵션을 추가하여 GC 최대 일시 중지 시간을 100ms로 설정하고 힙 메모리를 2GB로 고정하는 변경 사항을 담고 있습니다. G1GC를 사용하고 최대 일시 중지 시간을 설정하는 것은 서비스 응답 시간을 개선하기 위한 좋은 시도입니다. 다만, 힙 크기를 하드코딩하는 대신 환경 변수로 설정하여 유연성을 높이는 방안과, Java 21에서 기본값인 G1GC 설정 옵션의 중복성에 대해 몇 가지 개선 의견을 제안합니다.
| "-Xms2g", | ||
| "-Xmx2g", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타