Skip to content

perf: DockerFile 수정 #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wlgns12370 merged 3 commits into from
Nov 4, 2025
Merged

perf: DockerFile 수정 #399

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0b9074
MOSU-395 fix: Dockerfile 문법 수정
wlgns12370 Nov 4, 2025
be1753c
MOSU-395 refactor: GC 옵션 ENV 분리
wlgns12370 Nov 4, 2025
a7f75d6
Merge pull request #398 from mosu-dev/perf/mosu-395
wlgns12370 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
FROM amazoncorretto:21
COPY build/libs/*SNAPSHOT.war app.war

ENTRYPOINT [
"java",
"-Duser.timezone=GMT+9",
"-Djava.security.egd=file:/dev/./urandom",
"-XX:+UseG1GC",
"-XX:MaxGCPauseMillis=100",
"-Xms2g",
"-Xmx2g",
"-jar", "/app.war"
]
ENV JAVA_OPTS="-XX:+UseG1GC -XX:MaxGCPauseMillis=100 -Xms2g -Xmx2g"
ENTRYPOINT ["sh", "-c", "exec java -Duser.timezone=GMT+9 $JAVA_OPTS -jar /app.war"]
Comment on lines +4 to +5
Copy link

@gemini-code-assist gemini-code-assist bot Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

JAVA_OPTS 환경 변수를 도입하여 JVM 옵션을 외부에서 주입할 수 있도록 변경한 점은 좋은 개선입니다. 다만, 일관성을 위해 -Duser.timezone=GMT+9 옵션도 JAVA_OPTS에 포함하는 것이 더 좋을 것 같습니다. 이렇게 하면 모든 JVM 관련 설정을 한 곳에서 관리하고 오버라이드할 수 있어 유지보수성이 향상됩니다.

ENV JAVA_OPTS="-Duser.timezone=GMT+9 -XX:+UseG1GC -XX:MaxGCPauseMillis=100 -Xms2g -Xmx2g"
ENTRYPOINT ["sh", "-c", "exec java $JAVA_OPTS -jar /app.war"]