MOSU-32 feature: 학생 정보 목록 조회 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyglot-k
approved these changes
Jul 5, 2025
Contributor
polyglot-k
left a comment
polyglot-k
left a comment
There was a problem hiding this comment.
오 별다르게 리뷰할게 없습니다! 견고하고 좋은 코드 같습니다 :) ✅
Comment on lines
31
to
36
| for (FileRequest req : requests) { | ||
| fileUploadHelper.updateTag(req.s3Key()); | ||
| faqAttachmentRepository.save(req.toAttachmentEntity( | ||
| req.fileName(), req.s3Key(), faqId | ||
| )); | ||
| } |
Contributor
There was a problem hiding this comment.
for..in이랑 .forEach() 랑 어떨 때 쓰시나요??
Comment on lines
78
to
83
| private Predicate buildNameCondition(QProfileJpaEntity profile, String name) { | ||
| if (name != null && !name.isBlank()) { | ||
| return profile.userName.contains(name); | ||
| } | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
보통 선행 if에서 null을 return 하도록하는게 관례상 에러 기저를 먼저 잡는 느낌이라서 깔끔한거 같아요!
Comment on lines
85
to
90
| private Predicate buildPhoneCondition(QProfileJpaEntity profile, String phone) { | ||
| if (phone != null && !phone.isBlank()) { | ||
| return profile.phoneNumber.contains(phone); | ||
| } | ||
| return null; | ||
| } |
wlgns12370
reviewed
Jul 5, 2025
Comment on lines
23
to
25
| @RequestParam(required = false) String name, | ||
| @RequestParam(required = false) String phone, | ||
| @RequestParam(defaultValue = "desc") String order, |
Contributor
There was a problem hiding this comment.
public record StudentFilter(
String name,
String phone,
String order
) {
public StudentFilter {
if (order == null || order.isBlank()) {
order = "desc";
}
}
}getStudents( @ModelAttribute StudentFilter filter )이런식으로 필드를 합치는건 어떤가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타