stop()#2
Conversation
|
Sorry, completely forgot about this PR :/ The failing tests are probably toggling tests that might work again tomorrow, when Berlin Schwedter Str. has departures again (?). Nonetheless we should probably improve these at some point... Apart from that, LGTM 👍 Regarding |
no worries, it went out of my mind, too. Otherwise, I would've sent a quick reminder 👍
The responses would remain the way they are. |
|
Ok there's still no departures at Schwedter Str. :( Need to look at that, but very likely unrelated to your PR. Ah yes now I understand but I think for that we first would need to build a corresponding API into MOTIS. In the DB APIs you should be able to use the |
Ohh, that's interesting to know. Thx!
I think I would not do that, since it would be problematic if names are not unique. (I.e. there seem to be at least four places with the name "LOL" and at least five places named "Lol" in Transitious 😅) |
resolves #1.
Since
parseLocation()does everything aparseStop()function would need to do, I deleted it. Let me know if I overlooked something here.Only somewhat related, but I was wondering if adding a
location()endpoint (or just expanding thestop()endpoint to also work on location ids) would make sense to implement some time in the future🤔. This could make downstream apis a little leaner, as passing the full location object would no longer be necessary in some places. For now, this is not possible of course, since/stoptimesonly accepts station/stop ids.