Reflect config in the UI #1186
Reflect config in the UI #1186
Conversation
openapi.yaml
Outdated
| - lat | ||
| - lon | ||
| - zoom | ||
| - routeFootPath |
There was a problem hiding this comment.
hasElevation is missing (doesn't really matter, but for completeness)
openapi.yaml
Outdated
| hasElevation: | ||
| description: true if elevation is loaded | ||
| type: boolean | ||
| routeFootPath: |
There was a problem hiding this comment.
I think routedTransfersAvailable would be a better name, since this is really only for intermediate transfers, pre and post transit is always available when osm is loaded. For the config.yml field street_routing there should be an additional field e.g. streetRoutingAvailable that removes all settings after the maximum number of transfers in the advanced settings (first/last/direct/elevation). For consistency, then rename to elevationAvailable (or everything with has...)
Maybe also extend the description of the initial endpoint to better explain what these values are about.
ui/src/lib/AdvancedOptions.svelte
Outdated
| } | ||
| }} | ||
| /> | ||
| {#if routeFootPath} |
There was a problem hiding this comment.
This should also encompass wheelchair below (because this in turn is only selectable if routedTransfers are enabled). Alternative: disable instead of hide
ui/src/lib/AdvancedOptions.svelte
Outdated
| maxPrePostTransitTimeLimit, | ||
| maxDirectTimeLimit, | ||
| hasElevation, | ||
| routeFootPath, |
There was a problem hiding this comment.
maybe put this into an object so that we don't have to pass around 4-5 values everywhere?
openapi.yaml
Outdated
| description: enable routing footpaths | ||
| type: boolean | ||
| maxTravelTimeLimit: | ||
| description: limit for maxTravelTime API param |
There was a problem hiding this comment.
specify that this applies to onetoall only (at least in the description, maybe also in the name of the field?)
|
Eventually, the routed transfers will be available per profile (car, bike, wheelchair, baby buggy, etc etc). |
3 participants
fixes #1035