-
Notifications
You must be signed in to change notification settings - Fork 105
replace dummy leg with surface-level routing fallback #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Any concrete example where this helps? As with the other PR: I would also recommend to discuss your approach before starting to work on something for several reasons:
|
|
I'm pretty sure this does not fix #966 as there we don't want any footpath to be found at all. |
It requires a 1,5h walk to the next bridge. This is not something we want to consider for transfers. It's not about how the transfer is being displayed but more about the wrong transfer time and that we have a transfer time limit that's way below 1,5h. |
|
Okay, so if we knew the travel time was 1.5h, we wouldn’t show it at all. |
|
Not just that. Since this unrealistic journey probably dominated other (more useful and realistic) alternatives during the routing, we would maybe even show something more useful instead. In order to show these alternatives, we are not allowed to produce a transfer here at all (at least not with 2min when it actually takes 1,5h). Besides that it doesn't solve #966 regarding this actual PR:
|
|
How do you plan to fix this when some OSM data is simply broken for certain stations (e.g. Rondo ONZ in Warsaw)? How will you distinguish between missing stairs that connect the platform with the surface, and missing a bridge across a river? |
|
OSM is not set in stone. More or less the opposite is the case: everyone is invited to fix broken data. So "simply broken" today could mean that it's already fixed tomorrow. That would always be the preferred option as it provides the best information to users. However, I am not opposing this PR to make the routing for the path display more robust against broken OSM data. With a transfer time limit of 20min the case in Warsaw will produce a valid transfer while the bridge case will still find anything on OSM data. The primary problem with the bridge case is that no routing was involved at all because we don't have |

This PR improves the fallback mechanism for pedestrian routing when a path cannot be found, particularly between different levels (e.g., underground to surface).
Currently, a failed routing attempt results in a "dummy leg" based on a straight-line distance, which is unrealistic and misleading for the user.
Fixes #966