Skip to content

Added parameter threshold to modulate the restrictiveness the Recaptcha response #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ohduran wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added parameter threshold to modulate the restrictiveness the Recaptcha response #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions recaptcha/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
import os
import json
import os

import requests

from django.conf import settings
from django.utils.translation import ugettext_lazy as _

from rest_framework import serializers

from .constants import GR_CAPTCHA_TEST_SECRET_KEY, GR_CAPTCHA_DEFAULT_URL
from .constants import GR_CAPTCHA_DEFAULT_URL, GR_CAPTCHA_TEST_SECRET_KEY


class ReCaptchaField(serializers.CharField):

extra_error_messages = {
'write_only': _('This is a write only field'),
'missing-input-secret': _('Secret key is missing. Please contact admin.'),
Expand All @@ -23,6 +24,13 @@ class ReCaptchaField(serializers.CharField):
default_error_messages = serializers.CharField.default_error_messages.copy()
default_error_messages.update(extra_error_messages)

def __init__(self, **kwargs):
self.threshold = kwargs.pop('threshold', None)
if self.threshold:
assert isinstance(self.threshold, float) or isinstance(self.threshold, int), \
'threshold must be a number'
super(ReCaptchaField, self).__init__(**kwargs)

def to_representation(self, obj):
self.fail('write_only')

Expand All @@ -39,10 +47,21 @@ def to_internal_value(self, data):
})
return_values = json.loads(res.content.decode())
return_code = return_values.get("success", False)
score = return_values.get("score", 0.0)
error_codes = return_values.get('error-codes', [])
if not return_code:
if error_codes and error_codes[0] in self.default_error_messages.keys():
self.fail(error_codes[0])

if self.threshold:
if self.threshold <= score:
return data
else:
self.fail('bad-request')
self._raising_error_codes(error_codes=error_codes)

if not return_code:
self._raising_error_codes(error_codes=error_codes)
return data

def _raising_error_codes(self, error_codes):
if error_codes and error_codes[0] in self.default_error_messages.keys():
self.fail(error_codes[0])
else:
self.fail('bad-request')