Skip to content

Optimize date parsing in normalize_cansim_values #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mountainMath wants to merge 1 commit into
base: v0.4.5
Choose a base branch
from
Open

Optimize date parsing in normalize_cansim_values #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions R/cansim.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,37 @@ normalize_cansim_values <- function(data, replacement_value="val_norm", normaliz
if (!trad_cansim) {
# do nothing
} else if (grepl("^\\d{4}$",sample_date)) {
# year
data <- data %>%
mutate(Date=as.Date(paste0(!!as.name(date_field),"-",default_month,"-",default_day)))
# year - use lookup table for efficiency
unique_dates <- unique(data[[date_field]])
date_lookup <- setNames(
as.Date(paste0(unique_dates, "-", default_month, "-", default_day)),
unique_dates
)
data$Date <- unname(date_lookup[data[[date_field]]])
} else if (grepl("^\\d{4}/\\d{4}$",sample_date)) {
# year range, use second year as anchor
data <- data %>%
mutate(Date=as.Date(paste0(gsub("^\\d{4}/","",!!as.name(date_field)),"-",default_month,"-",default_day)))
# year range, use second year as anchor - use lookup table for efficiency
unique_dates <- unique(data[[date_field]])
date_lookup <- setNames(
as.Date(paste0(gsub("^\\d{4}/", "", unique_dates), "-", default_month, "-", default_day)),
unique_dates
)
data$Date <- unname(date_lookup[data[[date_field]]])
} else if (grepl("^\\d{4}-\\d{2}$",sample_date)) {
# year and month
data <- data %>% mutate(Date=as.Date(paste0(!!as.name(date_field),"-",default_day)))
# year and month - use lookup table for efficiency
unique_dates <- unique(data[[date_field]])
date_lookup <- setNames(
as.Date(paste0(unique_dates, "-", default_day)),
unique_dates
)
data$Date <- unname(date_lookup[data[[date_field]]])
} else if (grepl("^\\d{4}-\\d{2}-\\d{2}$",sample_date)) {
# year, month and day
data <- data %>%
mutate(Date=as.Date(!!as.name(date_field)))
# year, month and day - use lookup table for efficiency
unique_dates <- unique(data[[date_field]])
date_lookup <- setNames(
as.Date(unique_dates),
unique_dates
)
data$Date <- unname(date_lookup[data[[date_field]]])
}

cansimTableNumber <- cleaned_ndm_table_number(cansimTableNumber)
Expand Down