Enhance and fix Zoom methods #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunagm
requested changes
Jul 23, 2024
Collaborator
shaunagm
left a comment
shaunagm
left a comment
There was a problem hiding this comment.
One minor docstring update needed, plus the tests will need to pass before we can merge
austinweisgrau
force-pushed
the
zoom_polls
branch
from
f0f16f1 to
4a5fbe0
Compare
austinweisgrau
force-pushed
the
zoom_polls
branch
from
4a5fbe0 to
f958e36
Compare
Collaborator
Author
|
Weirdly I'm not able to reproduce this test_gmail.py error locally but will dig in when I have a moment |
Collaborator
austinweisgrau
force-pushed
the
zoom_polls
branch
3 times, most recently
from
f417e6e to
cce145e
Compare
austinweisgrau
force-pushed
the
zoom_polls
branch
from
cce145e to
4689216
Compare
austinweisgrau
force-pushed
the
zoom_polls
branch
from
4689216 to
83d745b
Compare
austinweisgrau
force-pushed
the
zoom_polls
branch
from
83d745b to
9d75079
Compare
shaunagm
approved these changes
Jan 29, 2025
Collaborator
|
This looks ready to merge to me! Is it good on your end? |
austinweisgrau
force-pushed
the
zoom_polls
branch
from
9d75079 to
928eafd
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes to the Zoom connector.
get_past_meeting_poll_metadatamethod is fixed