Skip to content

Dev tooling updates #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shaunagm merged 12 commits into from
Feb 6, 2025
Merged

Dev tooling updates #1268

shaunagm merged 12 commits into from
Feb 6, 2025

Conversation

@bmos
Copy link
Contributor

@bmos bmos commented Feb 1, 2025 •
edited
Loading

What's Changed

  • Add comment summarizing changes to coverage + listing overall coverage [example]
  • ruff format now targets python 3.9+ since this is the lowest version we support.
  • ruff update will require some reformatting of files.
  • pycodestyle was in requirements-dev.txt but not used.
  • python-checks.yml workflow now runs on commits pushed to any branches, not just main and major-release.
  • pre-commit updated with new ruff version to match CI workflow (as this does not pull from requirements-dev.txt/ installed version)

@bmos bmos force-pushed the dev-tool-updates branch from ffb52aa to bdb5173 Compare February 2, 2025 15:28
@bmos bmos marked this pull request as ready for review February 2, 2025 15:45
@bmos bmos changed the title Dev tool updates Dev tooling version updates Feb 2, 2025
@bmos bmos changed the title Dev tooling version updates Dev tooling updates Feb 3, 2025
@bmos bmos force-pushed the dev-tool-updates branch from 5ddf9f3 to 11bbed2 Compare February 3, 2025 21:32
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2025
View reviewed changes
@bmos bmos marked this pull request as draft February 3, 2025 22:04
@bmos bmos force-pushed the dev-tool-updates branch from 11bbed2 to f7db538 Compare February 3, 2025 22:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2025
View reviewed changes
@bmos bmos force-pushed the dev-tool-updates branch 6 times, most recently from 4c01476 to 68cfcf2 Compare February 4, 2025 04:13
@bmos bmos marked this pull request as ready for review February 4, 2025 18:09
@bmos bmos force-pushed the dev-tool-updates branch from 68cfcf2 to fc9ae9c Compare February 4, 2025 18:09
@bmos
Copy link
Contributor Author

bmos commented Feb 4, 2025

If we go ahead with merging this, I will issue one more commit, which accepts the reformatted multi-line F-strings from ruff 0.9.0+

@bmos bmos force-pushed the dev-tool-updates branch from fc9ae9c to 07f403a Compare February 5, 2025 01:17
@bmos bmos force-pushed the dev-tool-updates branch from 943ccc3 to 2ca38c2 Compare February 6, 2025 04:00
@bmos bmos force-pushed the dev-tool-updates branch 2 times, most recently from 2e51bb6 to 7af4684 Compare February 6, 2025 17:41
shaunagm
shaunagm approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - and thanks for fixing my version naming error :)

@shaunagm shaunagm merged commit 1679c73 into move-coop:main Feb 6, 2025
69 checks passed
@bmos bmos deleted the dev-tool-updates branch February 6, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaunagm shaunagm shaunagm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmos @shaunagm