-
Notifications
You must be signed in to change notification settings - Fork 135
Daisychain connector #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Daisychain connector #1283
Conversation
bd7d391
to
e1957ba
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
@austinweisgrau is this still a work in progress? It's missing docs and tests but I can do a review of the code if you want, or I can wait til you're ready |
The code is good to go! I should prob add docs and tests tho huh
…On Tue, Feb 18, 2025, 1:57 PM Shauna Gordon-McKeon ***@***.***> wrote:
@austinweisgrau <https://github.com/austinweisgrau> is this still a work
in progress? It's missing docs and tests but I can do a review of the code
if you want, or I can wait til you're ready
—
Reply to this email directly, view it on GitHub
<#1283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO74QHTB7PQU2UWZQFPZJ5L2QOUDJAVCNFSM6AAAAABWVBE4OCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGAYTGNJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: shaunagm]*shaunagm* left a comment (move-coop/parsons#1283)
<#1283 (comment)>
@austinweisgrau <https://github.com/austinweisgrau> is this still a work
in progress? It's missing docs and tests but I can do a review of the code
if you want, or I can wait til you're ready
—
Reply to this email directly, view it on GitHub
<#1283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO74QHTB7PQU2UWZQFPZJ5L2QOUDJAVCNFSM6AAAAABWVBE4OCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGAYTGNJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I forget whether you've made a new connector before, but just in case you haven't or you forgot the steps, the new connector guide has all the details (probably too many details for your experience level!). Docs and tests sections are near the bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating the status to 'request changes' as we need docs/tests. No rush!
No description provided.