Add Introspection class for API key profiles with tests#1295
Add Introspection class for API key profiles with tests#1295shaunagm merged 7 commits intomove-coop:mainfrom
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
shaunagm
left a comment
There was a problem hiding this comment.
Can you tell me a bit about why you wanted to make an introspection class for this, as opposed to just calling .get_request("apiKeyProfiles") on the connection itself? Also you import and instantiate the logger but it doesn't seem to be used?
I created a new class because every endpoint used in the VAN connector is organized in a separate class. The logger was imported in every other class so just when I copied another class it came with it. I can add a simple log statement that confirms that a response came through. |
shaunagm
left a comment
There was a problem hiding this comment.
Thanks for the explanation, @matthewkrausse - I'd forgotten that fact about the NGPVan connector! And thanks for adding the logging.
Introduce an Introspection class to handle API key profiles and implement corresponding unit tests to validate functionality.
Issue #1180