Skip to content

Add Introspection class for API key profiles with tests#1295

Merged
shaunagm merged 7 commits intomove-coop:mainfrom
groundgametexas:krausse-issue-1180
Mar 11, 2025
Merged

Add Introspection class for API key profiles with tests#1295
shaunagm merged 7 commits intomove-coop:mainfrom
groundgametexas:krausse-issue-1180

Conversation

@matthewkrausse
Copy link
Collaborator

Introduce an Introspection class to handle API key profiles and implement corresponding unit tests to validate functionality.

Issue #1180

@github-actions
Copy link

github-actions bot commented Feb 16, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  parsons/ngpvan
  introspection.py 8
  van.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me a bit about why you wanted to make an introspection class for this, as opposed to just calling .get_request("apiKeyProfiles") on the connection itself? Also you import and instantiate the logger but it doesn't seem to be used?

@matthewkrausse
Copy link
Collaborator Author

Can you tell me a bit about why you wanted to make an introspection class for this, as opposed to just calling .get_request("apiKeyProfiles") on the connection itself? Also you import and instantiate the logger but it doesn't seem to be used?

I created a new class because every endpoint used in the VAN connector is organized in a separate class. The logger was imported in every other class so just when I copied another class it came with it. I can add a simple log statement that confirms that a response came through.

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, @matthewkrausse - I'd forgotten that fact about the NGPVan connector! And thanks for adding the logging.

@shaunagm shaunagm merged commit e6b281b into move-coop:main Mar 11, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants