Skip to content

Conversation

@austinweisgrau
Copy link
Collaborator

@austinweisgrau austinweisgrau commented Mar 12, 2025

Copies the auth structure from the other google connectors

To Do:

  • Tests
  • Docs

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  parsons/google
  google_drive.py 35-48, 56-72, 75-85, 90-109, 114-135, 138-140, 146-153, 156-164, 168-170, 174-190, 201-203, 207-209, 234-267, 279-300
Project Total  

This report was generated by python-coverage-comment-action

austinweisgrau and others added 2 commits July 28, 2025 15:03
@austinweisgrau austinweisgrau marked this pull request as ready for review July 28, 2025 22:17
@austinweisgrau austinweisgrau requested a review from shaunagm July 28, 2025 22:17
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing @austinweisgrau. The failing checks are formatting added by @bmos - should be an easy fix with command ruff format, let me know if you'd like me to handle that or if you can do so, either way once that's done we can merge this.

@bmos
Copy link
Contributor

bmos commented Sep 16, 2025

Generally ruff check --fix, not ruff format, but it seems like these aren't auto-fixes.
You can fix 3 by using ruff check --fix --unsafe-fixes, but the other 3 (all related to using Pathlib) require manual intervention (although the comments github posted tell you how to fix them).

@shaunagm
Copy link
Collaborator

Not to hijiack Austin's perfectly nice pull request to discuss ruff but is it a general rule that the pathlib fixes are not automatic while the others are? If the pathlib ones will consistently require manual fixing it might make sense to remove that requirement.

@bmos
Copy link
Contributor

bmos commented Sep 16, 2025

There is probably a way to only include pathlib rules that are autofixable, I will investigate.

@austinweisgrau
Copy link
Collaborator Author

Huh, why am I getting

$ ruff check --fix
All checks passed!

@austinweisgrau
Copy link
Collaborator Author

Nevermind I see the discussion now, I'll fix it

@austinweisgrau austinweisgrau merged commit a3b3b41 into move-coop:main Sep 25, 2025
84 checks passed
@austinweisgrau austinweisgrau deleted the drive branch September 25, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants