-
Notifications
You must be signed in to change notification settings - Fork 134
Google Drive connector #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Drive connector #1346
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Co-Authored-By: Elyse <elyse.g.weiss@gmail.com>
shaunagm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay reviewing @austinweisgrau. The failing checks are formatting added by @bmos - should be an easy fix with command ruff format, let me know if you'd like me to handle that or if you can do so, either way once that's done we can merge this.
|
Generally |
|
Not to hijiack Austin's perfectly nice pull request to discuss ruff but is it a general rule that the pathlib fixes are not automatic while the others are? If the pathlib ones will consistently require manual fixing it might make sense to remove that requirement. |
|
There is probably a way to only include pathlib rules that are autofixable, I will investigate. |
|
Huh, why am I getting |
|
Nevermind I see the discussion now, I'll fix it |
Copies the auth structure from the other google connectors
To Do: