Add command line args to .pre-commit-config bandit entry#1366
Closed
bmos wants to merge 6 commits intomove-coop:mainfrom
Closed
Add command line args to .pre-commit-config bandit entry#1366bmos wants to merge 6 commits intomove-coop:mainfrom
bmos wants to merge 6 commits intomove-coop:mainfrom
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
austinweisgrau
requested changes
Mar 24, 2025
Collaborator
austinweisgrau
left a comment
austinweisgrau
left a comment
There was a problem hiding this comment.
I ran pre-commit run --all and got
[main] ERROR pyproject.toml -r -ll -ii : Could not read config file.
bmos
force-pushed
the
pre-commit_bandit_args
branch
from
2d4fa0c to
845ad7d
Compare
bmos
force-pushed
the
pre-commit_bandit_args
branch
from
6223ff1 to
3f4c51a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bmos
force-pushed
the
pre-commit_bandit_args
branch
from
97f105b to
0e9c118
Compare
Collaborator
|
Hey @bmos , it seems like a lot of out-of-scope changes are now included in this PR, can you clarify? |
bmos
force-pushed
the
pre-commit_bandit_args
branch
from
0dbb94b to
6d9d30c
Compare
bmos
force-pushed
the
pre-commit_bandit_args
branch
from
6d9d30c to
94f9095
Compare
fgregg
reviewed
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bandit is flagging too much when run via pre-commit because it's missing the args we use in the documentation + ci workflow. I had included this in my first bandit pre-commit PR but I must have lost it when rebuilding the second PR.
Closes #1362