-
Couldn't load subscription status.
- Fork 135
Add Avro file support for Parsons Tables #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Avro file support for Parsons Tables #1371
Conversation
|
Looks like I am running into an issue with the limited dependencies. fastavro should be a dependency of the petl package but they are not being loaded in I guess. Wanted to chat through this before just adding fastavro to the limited dependency set which seems wrong. @austinweisgrau Have any thoughts here? |
|
For the limited dependencies setup, you need to add the dependency in the setup.py file. You'll want to think about if it should be an "extra" (so if people want to be able to use that functionality, they need to install parsons with By default, it should probably be the former (need to opt-in with parsons[avro]). |
|
Thanks. Made what I believe will fix it. Let's find out. |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
yep that's it! |
|
@shaunagm This is ready for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor docs changes requested but other than that this looks good
|
@matthewkrausse there's still a couple links without urls (to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just updating the status to reflect that there's still a couple changes needed (a few links without urls still)
Introduce functionality for reading and writing Avro files in the Table class, including methods for basic operations, schema handling, and support for various compression codecs.