Add a PR template #1439
Open
Add a PR template #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
shaunagm
requested changes
May 9, 2025
| - (List out any significant design decisions that were made and why.) | ||
|
|
||
| ## How to test the changes | ||
| - (How should a reviewer test this functionality) |
There was a problem hiding this comment.
Sometimes tests are not needed (ie for most docs changes) so maybe add an 'if possible/needed' to that part of the template?
Other than that, this looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always think this is helpful and encourages folks to leave better structured, richer explanations of their PRs. Happy to change this, are there are other items that should be included here so that folks remember to discuss them?