-
Notifications
You must be signed in to change notification settings - Fork 135
move project definitions to pyproject.toml #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e9e53b to
cf41e76
Compare
Collaborator
|
@bmos can you resolve the conflict, and then I can merge this PR? I'm 90% sure I know how to resolve the conflict correctly but not 100% so I'd rather have you do it. |
Contributor
Author
|
assuming the checks pass, this should be all set :) |
shaunagm
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous pass at this in #1015 got stuck because it removed the LIMITED_DEPENDENCIES / friendly dependencies feature and I was not confident enough to reimplement it, so I closed it.
Here is a more limited scope-approach that leaves the requirements.txt, requirements-dev.txt, and setup.py files handing dependencies, but moves project data and package selection to pyproject.toml
It also fixes #1515 by removing the upper bound of python versions, as we already support the latest release version of python and all of our code should be compatible, once dependencies are updated.