Skip to content

Conversation

@codybraun
Copy link
Contributor

What is this change?

  • Refresh the NewMode oauth token when it is expired- this is happening a lot more often now that we're correctly paginating through all the results!

Considerations for discussion

  • I mean arguably the token refresh failure shouldn't count towards your retries which it currently will but this also keeps things simpler and makes it more certain we're not giong to get stuck in some token-refresh loop since we do count those

How to test the changes (if needed)

  • Sort of headache to test since you have to wait for an expiration, added an automated test that I think we can feel good about
    pytest test -k test_token_refresh_on_expired_token

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  parsons/newmode
  newmode.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@willyraedy willyraedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunagm shaunagm merged commit b42d94a into main Jul 2, 2025
70 checks passed
@codybraun codybraun deleted the cody/fix/new-mode-reauth branch July 2, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants