Closed
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
bmos
force-pushed
the
patch-1
branch
2 times, most recently
from
0181196 to
44a900b
Compare
Resolved merge conflicts in requirements.txt by consolidating censusgeocode and urllib3 entries.
bmos
commented
Jan 23, 2026
bmos
commented
Jan 26, 2026
Comment on lines
+10
to
+14
| dbt-core>=1.9.0 | ||
| dbt-bigquery>=1.9.0 | ||
| dbt-postgres>=1.9.0 | ||
| dbt-redshift>=1.9.0 | ||
| dbt-snowflake>=1.9.0 |
Contributor
Author
There was a problem hiding this comment.
Hey @austinweisgrau!
Do you have thoughts on this?
The specific packages are not included in requirements but are in setup.py.
Is this intentional or does it make sense for me to have added them?
bmos
force-pushed
the
patch-1
branch
2 times, most recently
from
9362fc6 to
8bd3e1a
Compare
bmos
commented
Feb 4, 2026
setup.py
Outdated
Comment on lines
+27
to
+35
| "dbt-redshift": [ | ||
| "dbt-redshift >= 1.5.0", | ||
| "dbt-core >= 1.5.0", | ||
| "lxml;python_version < '3.14'", | ||
| "lxml>=5.5.0;python_version >= '3.14'", | ||
| ], | ||
| "dbt-bigquery": ["dbt-bigquery >= 1.5.0", "dbt-core >= 1.5.0"], | ||
| "dbt-postgres": ["dbt-postgres >= 1.5.0", "dbt-core >= 1.5.0"], | ||
| "dbt-snowflake": ["dbt-snowflake >= 1.5.0", "dbt-core >= 1.5.0"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Note
sqlalchemy had a <3 max version listed, but there is no version 3, so I removed that max version as we do not use this pattern elesewhere.
Note
censusgeocode has not had a release in a long time, but their repository contains an (unreleased) commit which does allow use on python 3.14 and resolves known security issues by updating urllib3 (#1652) and selenium (#1635). This PR changes our requirements file to download censusgeocode from github for the time being (including the specific unreleased commit).
Note
dbt-adapter packages no longer install dbt-core by default. I have added dbt-core to the connector extras that use it and added the dbt-adapters to the requirements file as they seemed to be missing.