Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
…t for skips, change type hint on dbt_manifest)
…ded overall_status property to parsons dbt Manifest class
bmos
commented
Feb 19, 2026
| def __init__(self, command: str, dbt_manifest: dbtManifest) -> None: | ||
| """A wrapper for dbt execution results.""" | ||
|
|
||
| def __init__(self, command: str, dbt_manifest: ExecutionResult) -> None: |
Contributor
Author
There was a problem hiding this comment.
@austinweisgrau The type hint change of dbt_manifest from dbtManifest to ExecutionResult is the primary thing I need your input on here.
It silenced a ton of "method not found" errors in my IDE which seemed to indicate that it was mistyped, but I don't know much about dbt to say for sure.
If it was mistyped, the variable name should probably be changed too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbt is an important database component, but we had no tests for how we integrate with it.
Closes #1332
What's Changed