Skip to content

APIConnector Typing / Documentation #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmos wants to merge 9 commits into
base: main
Choose a base branch
from
Open

APIConnector Typing / Documentation #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b57b7c8
Typing and documentation for APIConnector and OAuth2APIConnector
bmos May 3, 2026
c85dc27
Update newmode test expected regex
bmos May 3, 2026
e7b3bf3
Call get_request with keyword args
bmos May 3, 2026
956ecb9
Improved Return documentation in APIConnector
bmos May 3, 2026
1e3c7af
Use keyword args in all APIConnector *request methods
bmos May 3, 2026
b4e8f9a
Pass authentication to APIConnector as HTTPBasicAuth
bmos May 3, 2026
0f6ad1d
Merge branch 'main' into api_connector
bmos May 4, 2026
eb33f84
Clarify that most dicts are dict[str, Any]
bmos May 5, 2026
e7d8a43
Use more similar typing to the typeshed requests package
bmos May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions parsons/actblue/actblue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from typing import Literal

from requests import Response
from requests.auth import HTTPBasicAuth

from parsons import Table
from parsons.utilities import check_env
Expand Down Expand Up @@ -47,8 +48,10 @@ def __init__(
actblue_uri=None,
max_retries=None,
):
self.actblue_client_uuid = check_env.check("ACTBLUE_CLIENT_UUID", actblue_client_uuid)
self.actblue_client_secret = check_env.check("ACTBLUE_CLIENT_SECRET", actblue_client_secret)
self.actblue_client_uuid: str = check_env.check("ACTBLUE_CLIENT_UUID", actblue_client_uuid)
self.actblue_client_secret: str = check_env.check(
"ACTBLUE_CLIENT_SECRET", actblue_client_secret
)
self.uri = (
check_env.check("ACTBLUE_URI", actblue_uri, optional=True) or ACTBLUE_API_ENDPOINT
)
Expand All @@ -57,7 +60,7 @@ def __init__(
}
self.client = APIConnector(
self.uri,
auth=(self.actblue_client_uuid, self.actblue_client_secret),
auth=HTTPBasicAuth(self.actblue_client_uuid, self.actblue_client_secret),
headers=self.headers,
)
self.max_retries = check_env.check("ACTBLUE_MAX_RETRIES", max_retries, optional=True)
Expand Down
2 changes: 1 addition & 1 deletion parsons/action_builder/action_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def remove_tagging(

logger.info(f"Removing tag {tag_id} from {identifier or tagging_id}")
return self.api.delete_request(
f"campaigns/{campaign}/{endpoint.format(tag_id)}/{tagging_id}"
url=f"campaigns/{campaign}/{endpoint.format(tag_id)}/{tagging_id}"
)

def upsert_connection(self, identifiers, tag_data=None, campaign=None, reactivate=True):
Expand Down
Loading
Loading