Open
Conversation
Collaborator
|
Looks like there's a test failure here |
shaunagm
requested changes
Feb 20, 2024
Collaborator
shaunagm
left a comment
shaunagm
left a comment
There was a problem hiding this comment.
Just changing the review status to 'request changes' instead of 'approved' due to the test failure
* fix AssertionError: Expected 'copy_s3_to_gcs' to be called once. Called 0 times. the test was checking for the method to have been called, but the previous commit changed the call to another method. * Bump Multiple Docs Deps Around Sphinx (#975) * Bump multiple docs deps * Downgrade myst-parser --------- Co-authored-by: Soren Spicknall <soren@spicknall.us>
Collaborator
Collaborator
|
Thanks to @bmos the tests are now passing. Is this otherwise ready to merge? @austinweisgrau it seems like you have more context than me, if you can give it the thumbs up I will merge it. |
Collaborator
|
@willyraedy @austinweisgrau what's the status of this PR? The tests are passing now, but it's not clear whether this is still needed. Happy to help get it over the line if so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the migration, we generalized a function to use the Transfer Service to copy file(s) from an arbitrary bucket rather than having bespoke functions for S3, GCS etc. However, we missed one reference to the old file.
Austin this should get you started. Could stand some more manual testing and we should add a unit test here obviously. I can get to that probably post the Feb 5th release of BQ to the rest of the members but wanted to get you what I had.