Skip to content

Commit ed80159

Browse files
committed
Combine target_link_libraries
1 parent 9b0656c commit ed80159

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,11 @@ target_compile_options(${PROJECT_NAME} PRIVATE ${PROJECT_COMPILE_OPTIONS})
9090
target_include_directories(${PROJECT_NAME}
9191
PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
9292
$<INSTALL_INTERFACE:include/${PROJECT_NAME}>)
93-
target_link_libraries(${PROJECT_NAME} PUBLIC
94-
${THIS_PACKAGE_EXPORT_DEPENDS}
95-
)
9693
# Private libraries that are not transitively needed by downstream projects
97-
target_link_libraries(${PROJECT_NAME} PRIVATE assimp::assimp fcl ${QHULL_LIBRARIES})
94+
target_link_libraries(${PROJECT_NAME}
95+
PUBLIC ${THIS_PACKAGE_EXPORT_DEPENDS}
96+
PRIVATE assimp::assimp fcl ${QHULL_LIBRARIES}
97+
)
9898
target_include_directories(${PROJECT_NAME} PRIVATE ${QHULL_INCLUDE_DIRS})
9999

100100
if(BUILD_TESTING)

test/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ configure_file(resources/config.h.in "${CMAKE_CURRENT_BINARY_DIR}/resources/conf
77
include_directories(${CMAKE_CURRENT_BINARY_DIR})
88

99
ament_add_gtest(test_basics test_basics.cpp)
10-
target_link_libraries(test_basics ${PROJECT_NAME})
11-
target_link_libraries(test_basics PUBLIC Eigen3)
10+
target_link_libraries(test_basics ${PROJECT_NAME} PUBLIC Eigen3)
1211

1312
ament_add_gtest(test_point_inclusion test_point_inclusion.cpp)
1413
target_link_libraries(test_point_inclusion ${PROJECT_NAME})

0 commit comments

Comments
 (0)