-
Notifications
You must be signed in to change notification settings - Fork 213
Rolling: Add OMPL config to moveit_cpp.yaml #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e527b7
to
d2e7fa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Andy! Unfortunately, it is different from Humble.
See for example the latest moveit_resources
Panda config.
Specifically, notice the split of request_adapters
and response_adapters
, and that some of the adapters were renamed/removed.
Tagged @sjahr as his planning pipeline refactor from a little while back is what introduced this. moveit/moveit2#2429 and moveit/moveit2#2457
It may also be good to introduce something into this repo that actually tests the MoveItCpp pipeline modified here, because as far as CI is concerned, all is green.
I'll open a new PR to target Humble, and update this one per the new planning pipelines. Prob won't have time for a new test though. Sad to think how many thousands of people probably tried |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks!
It took me way too long to figure out why
moveit_cpp
was using the CHOMP planning pipeline. It's becauseompl
pipeline wasn't configured here, so MoveIt defaults to the first planning pipeline in the list.(I've only tested this on Humble, hopefully it hasn't changed since then.)