feat: Environments API#152
Open
l-monninger wants to merge 8 commits into
Open
Conversation
ganymedio
reviewed
Jun 12, 2025
Collaborator
There was a problem hiding this comment.
@l-monninger with
mtma-migrate-node migrate select --environment-testing --null
I'm getting
streaming DA blobs between heights 16 and 17
movement-full-node | 2025-06-12T16:54:55.649597Z INFO movement_full_node::node::tasks::execute_settle: Receive DA heartbeat
Gracefully stopping... (press Ctrl+C again to force)
Error response from daemon: no container with ID 0621090da55d000647aec28338ea184a13acf946902a8ad81dc5ece23150127d found in database: no such container
error: Recipe `movement-full-node` failed on line 6 with exit code 1
Any idea what the cause might be?
I recall we had this error before but don't remember what the fix was.
feat: add unused dependency checks to pre-commit hook
Contributor
Author
@andygolay This is the correct behavior. It's just the logs from when |
Contributor
Author
|
@andygolay I'm going to leave this open until a get a few more eyes on. |
Collaborator
Sounds good, reviewing #155 now, probably best to merge that first too before this. |
sebtomba
reviewed
Jun 13, 2025
sebtomba
reviewed
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provides initial structure of the Environments API as prompted in #150 and an implementation for the
testingenvironment.You can see this in action with the CLI and the select API by running the
mtma-migrate-node migrate selectcommand:Tip
The flag
--environment-testing.*is the inverse naming of the structTestingEnvironmentintentionally. It is meant to convey the sense that you are selecting amongst several environments which would be prefixed--environment-*.Warning
I did not add any additional tests because the logic for assembling the testing environment is identical to what is already tested. However, it would be a good idea to refactor tests to use the Environments API in which case it would also be good to write
build_movement_migratortest.I would suggest an issue and follow-on PR.
Note
I have also provided structure for the
boxandprovisionerenvironments and an example of the how the select API is used to handle choosing one Environment. But, I have left them unimplemented.PRs involved