feat: scaffold process-compose#1184
Conversation
|
I noticed this error in the Build CI check: |
There was a problem hiding this comment.
Should this file be gitignored?
There was a problem hiding this comment.
It's mistake. I remove it.
There was a problem hiding this comment.
Should this file be gitignored?
|
The error is strange, I run the |
|
For the first error you should have started from a previous .movement with a wrong start Da height. |
|
With latest changes, load and soak tests fail with an error in the |
|
After a811e23, load test fails with transactions timed out at default settings. The soak test also reports transactions timed out, and after a while block production stops, though the test continues running. |
There was a problem hiding this comment.
@musitdev not sure whether you want to fix in this PR but with cargo check --all-targets I get a few errors:
error[E0308]: mismatched types
--> protocol-units/execution/maptos/fin-view/src/fin_view.rs:87:56
|
87 | let mut executor = Executor::try_from_config(config, mempool_tx_exec_result_sender).await?;
| ------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `UnboundedSender<Vec<...>>`, found `Sender<Vec<...>>`
| |
| arguments to this function are incorrect
|
= note: expected struct `tokio::sync::mpsc::UnboundedSender<Vec<TxExecutionResult>>`
found struct `futures::futures_channel::mpsc::Sender<Vec<TxExecutionResult>>`
note: associated function defined here
--> /Users/andygmove/Downloads/repos/movement/protocol-units/execution/maptos/opt-executor/src/executor/initialization.rs:141:15
|
141 | pub async fn try_from_config(
| ^^^^^^^^^^^^^^^
warning: unused variable: `tx_sender`
--> protocol-units/execution/maptos/dof/src/v1.rs:560:8
|
560 | let (tx_sender, _tx_receiver) = mpsc::channel::<Vec<(u64, SignedTransaction)>>(16);
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_sender`
error[E0061]: this method takes 2 arguments but 1 argument was supplied
--> protocol-units/execution/maptos/fin-view/src/fin_view.rs:88:47
|
88 | let (context, _transaction_pipe) = executor.background(mempool_commit_tx_receiver)?;
| ^^^^^^^^^^---------------------------- an argument of type `futures::futures_channel::mpsc::Sender<MempoolClientRequest>` is missing
|
note: expected `UnboundedReceiver<Vec<...>>`, found `Receiver<Vec<...>>`
--> protocol-units/execution/maptos/fin-view/src/fin_view.rs:88:58
|
88 | let (context, _transaction_pipe) = executor.background(mempool_commit_tx_receiver)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: expected struct `tokio::sync::mpsc::UnboundedReceiver<Vec<TxExecutionResult>>`
found struct `futures::futures_channel::mpsc::Receiver<Vec<TxExecutionResult>>`
note: method defined here
--> /Users/andygmove/Downloads/repos/movement/protocol-units/execution/maptos/opt-executor/src/executor/initialization.rs:201:9
|
201 | pub fn background(
| ^^^^^^^^^^
help: provide the argument
|
88 | let (context, _transaction_pipe) = executor.background(/* tokio::sync::mpsc::UnboundedReceiver<Vec<TxExecutionResult>> */, /* futures::futures_channel::mpsc::Sender<MempoolClientRequest> */)?;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
warning: `maptos-dof-execution` (lib test) generated 5 warnings
error[E0277]: `Result<movement_types::block::BlockCommitment, anyhow::Error>` is not a future
--> protocol-units/execution/maptos/fin-view/src/fin_view.rs:156:34
|
156 | executor.execute_block(block).await?;
| -^^^^^
| ||
| |`Result<movement_types::block::BlockCommitment, anyhow::Error>` is not a future
| help: remove the `.await`
|
= help: the trait `futures::Future` is not implemented for `Result<movement_types::block::BlockCommitment, anyhow::Error>`, which is required by `Result<movement_types::block::BlockCommitment, anyhow::Error>: std::future::IntoFuture`
= note: Result<movement_types::block::BlockCommitment, anyhow::Error> must be a future or must implement `IntoFuture` to be awaited
= note: required for `Result<movement_types::block::BlockCommitment, anyhow::Error>` to implement `std::future::IntoFuture`
warning: `movement-signer-test` (test "signer") generated 1 warning
Some errors have detailed explanations: E0061, E0277, E0308.
For more information about an error, try `rustc --explain E0061`.
warning: `maptos-fin-view` (lib test) generated 1 warning
error: could not compile `maptos-fin-view` (lib test) due to 3 previous errors; 1 warning emitted
|
@andygolay I have fixed the test build. |



Summary
protocol-units,networks,scripts,util,cicd, ormisc.Update process compose stack to start the new Da Sequencer.
Changelog
These changes have been tested using a network of 2 full nodes and one da-sequencer.
Testing
To start the stack alone:
To run the load test:
To run the soak test
Outstanding issues
Celestia is a mock.