Skip to content

fix: build#1198

Closed
ganymedio wants to merge 1 commit into
feature/da-sequencer-nodefrom
andygolay/fix-build
Closed

fix: build#1198
ganymedio wants to merge 1 commit into
feature/da-sequencer-nodefrom
andygolay/fix-build

Conversation

@ganymedio
Copy link
Copy Markdown
Contributor

@ganymedio ganymedio commented Apr 10, 2025

Summary

Testing

  • Build CI check passes.

@ganymedio ganymedio marked this pull request as ready for review April 10, 2025 21:09
@ganymedio ganymedio requested a review from sebtomba April 10, 2025 21:09
musitdev
musitdev reviewed Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@musitdev musitdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done these changes and others related to heartbeat in the PR #1184. If it's not urgent, we should wait to the #1184 PR. It will avoid me do redo a merge and solve conflict.

@ganymedio
Copy link
Copy Markdown
Contributor Author

ganymedio commented Apr 11, 2025

Closing this because as long as 1184 goes in without build errors, all will be well.

@ganymedio ganymedio closed this Apr 11, 2025
@ganymedio ganymedio deleted the andygolay/fix-build branch April 18, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@musitdev musitdev musitdev left review comments

@0xmovses 0xmovses Awaiting requested review from 0xmovses

@mzabaluev mzabaluev Awaiting requested review from mzabaluev

@sebtomba sebtomba Awaiting requested review from sebtomba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ganymedio @musitdev