feat: test core_resources_rotation#1288
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive testing infrastructure for core resources rotation functionality in the Movement framework. It introduces a new test module that reuses the pre-l1-merge commit configuration with rotated core-resource-account settings and provides end-to-end testing capabilities.
- Created a dedicated framework release module for testing core resources rotation
- Added process composition configuration files for different test scenarios
- Integrated new e2e test binaries for core resources rotation testing
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| protocol-units/execution/maptos/framework/releases/pre-l1-merge/Cargo.toml | Updated package description for clarity |
| protocol-units/execution/maptos/framework/releases/core-resources-rotation/src/lib.rs | Main library defining pre-l1-merge release configuration for rotation testing |
| protocol-units/execution/maptos/framework/releases/core-resources-rotation/src/cached.rs | Cached release implementation with gas upgrades, script modules, and feature flags |
| protocol-units/execution/maptos/framework/releases/core-resources-rotation/build.rs | Build script for framework release generation |
| protocol-units/execution/maptos/framework/releases/core-resources-rotation/Cargo.toml | Package configuration and dependencies for the test module |
| process-compose/movement-full-node/process-compose.test-upgrade-framework-rotated-key.yml | Process composition for framework upgrade with rotated keys |
| process-compose/movement-full-node/process-compose.test-core-resources-rotation.yml | Process composition for core resources rotation testing |
| networks/movement/movement-client/Cargo.toml | Added new e2e test binary for core resources rotation |
Comments suppressed due to low confidence (1)
protocol-units/execution/maptos/framework/releases/core-resources-rotation/build.rs:5
- The struct name
BiarritzRc1is inconsistent with thePreL1Mergestruct used in lib.rs. Consider using consistent naming across the module.
BiarritzRc1, // Struct name
|
Some notes on this PR. I've found that after rotating the keys (successfully) for the core_resources account it is unable to sign off on the proposal, the VM reverts with My Conclusion IsIt is not safe to rotate the core_resource signer and then attempt to sign off on governance proposasl with the rotated core_resource account. I propose thatWe use the current account to proceed with all the framework signing and do not rotate this key. If anyone is curious the code for the test and the cmds to run those tests are all in the PR description above. |
Pull Request Overview
This PR adds testing infrastructure for core resources rotation functionality in the Movement framework. It includes a new test release module that reuses the pre-l1-merge commit with rotated core-resource-account settings and adds an end-to-end test for core resources rotation.
Changelog
Testing
core_resourcesaccount rotation.IMPORTANT
Remember to
rm -rf .movement/before each run. Otherwise you'll get errors.Notes