Updated install scripts to allow user defined virtualenv directory #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a variable to the config file: VIRTUALENV_PATH
Now instead of being predefined, the virtualenv is activated or created in the specified directory. Default value is the same as the previous predefined path.
If created, ownership is then given to the current user to avoid 'permission denied' errors for creating the virtualenv using sudo.
Also changed install script to only install api calling "pip" when using virtualenv, instead of calling "pip2" and "pip3" separately. As virtualenv only has one python version, this caused the api to be installed for the virtualenv but also for the local user on one version of python.
Finally, changed uninstall script to activate virtualenv before uninstalling.