Save success dialog and unsaved changes exit confirmation - #20
Merged
mowi12 merged 3 commits intoMar 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the Textual UI flow around saving and exiting by adding modal dialogs for (1) confirming exit when there are unsaved changes and (2) presenting options after a save completes, aligning the app’s UX with issue #19.
Changes:
- Added
UnsavedChangesModalandSaveSuccessModalmodal screens to confirm risky exits and to present post-save actions. - Updated
action_saveto show a post-save modal instead of immediately exiting, and added state refresh after save. - Refactored add/remove computation into
_repos_to_add(),_repos_to_remove(), and_has_unsaved_changes()helpers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/mr_manager/ui.py |
Introduces modal screens and updates save/quit flows to provide confirmation dialogs and post-save choices. |
src/mr_manager/ui.tcss |
Adds styling for the new modal screens and their dialog layouts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mowi12
force-pushed
the
feat/19-feature-save-success-dialog-and-unsaved-changes-exit-confirmation
branch
from
March 24, 2026 21:25
070fa08 to
aae17d5
Compare
mowi12
deleted the
feat/19-feature-save-success-dialog-and-unsaved-changes-exit-confirmation
branch
March 24, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #19
Changes
Checklist
Either tick the items or cross out those that do not apply (using
example text) and provide a brief explanation why they do not apply.Author