Revert field name and restore original config format - #65
Merged
mowi12 merged 2 commits intoMay 10, 2026
Merged
Conversation
- Rename 'discovery.root' back to 'discovery.root_path' - Restore original config element order (root_path first, cache_ttl_hours second) - Remove unnecessary single quotes from path values
🚀 Performance Benchmark Results |
There was a problem hiding this comment.
Pull request overview
This PR addresses #64 by reverting a breaking change in the user config format, aiming to restore the pre-v1.0.0 key name and output style for ~/.config/mr-manager/config.yaml.
Changes:
- Switch config loading back to
discovery.root_path(fromdiscovery.root). - Update config saving to emit
root_pathfirst andcache_ttl_hourssecond. - Remove forced single-quoting of the saved
root_pathvalue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mowi12
enabled auto-merge
May 10, 2026 17:44
mowi12
deleted the
fix/64-bug-configuration-field-renamed-to-root-and-order-changed-in-v100
branch
May 10, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #64
Changes
How to Test
mr-managerand save unchanged configs in editorChecklist
Either tick the items or cross out those that do not apply (using
example text) and provide a brief explanation why they do not apply.Author