Skip to content

Use makefiles for build#841

Merged
aittalam merged 11 commits into
new_build_wipfrom
common_build
Dec 12, 2025
Merged

Use makefiles for build#841
aittalam merged 11 commits into
new_build_wipfrom
common_build

Conversation

@aittalam

@aittalam aittalam commented Dec 9, 2025

Copy link
Copy Markdown
Member

Moving the llama.cpp to makefiles to simpify integration with the rest of llamafile's code.

  • added BUILD.mk so we can do without cmake
  • build works with cosmocc 4.0.2
  • dependencies are all taken from llama.cpp/vendor directory
  • building now works out of the box both on linux and mac

see README_0.10.0.md for further updates

@aittalam aittalam requested a review from peteski22 December 9, 2025 20:13

@peteski22 peteski22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @aittalam 👍🏼

I added a couple of comments, and I'd just add we (I can help) should test this on Linux as well as MacOS before we merge anything to main later on.

Thanks! 😄

Comment thread build/config.mk Outdated
Comment thread build/rules.mk
aittalam and others added 3 commits December 12, 2025 15:26
Co-authored-by: Peter Wilson <peter@mozilla.ai>
Co-authored-by: Peter Wilson <peter@mozilla.ai>
@aittalam

Copy link
Copy Markdown
Member Author

Amazing @aittalam 👍🏼

I added a couple of comments, and I'd just add we (I can help) should test this on Linux as well as MacOS before we merge anything to main later on.

Thanks! 😄

Thank you! 🙏 I agree, I have tested this on linux too but we should make sure this is tested automatically every time: we do have code to do that on CI, I just have broken the build process atm 😅 but we'll make sure it is ok before we merge the new_build_wip branch with main

@aittalam aittalam merged commit 733d16c into new_build_wip Dec 12, 2025
1 check passed
@aittalam aittalam deleted the common_build branch December 12, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants