Add gpu accel probe#953
Merged
Merged
Conversation
Member
Author
Code reviewFound 1 issue:
Lines 188 to 208 in bb81581 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Member
Author
|
Fix looks good. Making 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a probe to loop through the different libraries and check not just whether they load properly, but also whether they are able to see any GPU.
PR Type
Relevant issues
Fixing an issue found while testing for release.
Problem: if running the current code in main, if both ggml-rocm.so and ggml-cuda.so are available but ggml-rocm.so finds no GPUs, llamafile starts with ROCm supports and 0 GPUs loaded even if we have an NVIDIA one available. The probe code instead loops through all supported libs and then chooses only the ones that see at least 1 GPU, in this order: CUDA > ROCm > Vulkan.
Checklist
AI Usage Information