api, ui: improve base view classes (bug 2039353)#1160
Draft
zzzeid wants to merge 1 commit into
Draft
Conversation
|
View this pull request in Lando to land it once approved. |
zzzeid
force-pushed
the
zeid/bug-2039353-view-base-classes-mixin
branch
3 times, most recently
from
8e43252 to
37d2a8c
Compare
- add BaseLandoViewMixin - add mixin to base view classes - use self.response where applicable - replace usages of Http404 with helper (bug 2039353)
zzzeid
force-pushed
the
zeid/bug-2039353-view-base-classes-mixin
branch
from
37d2a8c to
3a18fbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.