Skip to content

pull_request: add ability to edit commit message from PR in Lando UI#1161

Draft
Magnolia-Liu wants to merge 17 commits into
mainfrom
magnolia/bug-2003888-adding-edit-commit-msg
Draft

pull_request: add ability to edit commit message from PR in Lando UI#1161
Magnolia-Liu wants to merge 17 commits into
mainfrom
magnolia/bug-2003888-adding-edit-commit-msg

Conversation

@Magnolia-Liu
Copy link
Copy Markdown
Contributor

@Magnolia-Liu Magnolia-Liu commented May 14, 2026

  • modify view to be called by GitHub to update pull request content with data from Lando
  • add editable commit body and title fields
  • add save commit message button which refreshes page
  • add error display for invalid input

TO DO:

  • improve usability eg. disable editing during save, disabling pr button while saving, changing font + textbox size, etc.
  • add tests
  • make error handling more robust ie. pulling errors directly from github alongside using form checks, making character limit more strict/add warnings to better align with readability standards

@Magnolia-Liu Magnolia-Liu requested review from cgsheeh, shtrom and zzzeid May 14, 2026 17:36
@github-actions
Copy link
Copy Markdown

View this pull request in Lando to land it once approved.

Copy link
Copy Markdown
Contributor

@zzzeid zzzeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few drive-by comments

Comment thread src/lando/utils/github.py
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce chances of this PR getting blocked, we can take out the portions in this PR that were borrowed from #1073 and instead just keep the _patch and _patch methods. We can always re-add the delimiter functionality after that PR is more robust.

Comment thread src/lando/api/views.py


class PullRequestContentAPIView(PullRequestAPIView):
def put(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add docstrings to this method and the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants