pull_request: add ability to edit commit message from PR in Lando UI#1161
Draft
Magnolia-Liu wants to merge 17 commits into
Draft
pull_request: add ability to edit commit message from PR in Lando UI#1161Magnolia-Liu wants to merge 17 commits into
Magnolia-Liu wants to merge 17 commits into
Conversation
|
View this pull request in Lando to land it once approved. |
zzzeid
reviewed
May 14, 2026
Contributor
zzzeid
left a comment
There was a problem hiding this comment.
Just a few drive-by comments
Contributor
There was a problem hiding this comment.
To reduce chances of this PR getting blocked, we can take out the portions in this PR that were borrowed from #1073 and instead just keep the _patch and _patch methods. We can always re-add the delimiter functionality after that PR is more robust.
|
|
||
|
|
||
| class PullRequestContentAPIView(PullRequestAPIView): | ||
| def put( |
Contributor
There was a problem hiding this comment.
Would be good to add docstrings to this method and the class.
…adding-edit-commit-msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO DO: