Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1824139 - URL is broken if it contains bugXXX #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug 1824139 - URL is broken if it contains bugXXX #37

wants to merge 1 commit into from

Conversation

dklawren
Copy link
Collaborator

@dklawren dklawren commented Mar 23, 2023 •
edited
Loading

This patch updates the regexp to use word boundaries (\b) so now if we are in a URL it will not try to linkify bugXXX to BMO.

@dklawren dklawren requested a review from cgsheeh March 23, 2023 16:26
cgsheeh
cgsheeh approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if we have a test for this we should add a case to cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgsheeh cgsheeh cgsheeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dklawren @cgsheeh