Attribute preservation, RADb mirroring, and Jira diff output#2
Merged
Conversation
Replaces per-route print statements with a Summary collector that emits a
{code:diff} block at the end of each run. Created routes render green (+),
deleted routes render red (-), and updated routes appear as neutral context
lines. Dry-run mode is indicated in the header and uses the same prefixes
to show what would change.
Client dry-run return values are now 'dry-run-create', 'dry-run-update',
and 'dry-run-delete' so callers can distinguish the intended operation.
…to RADb - Replace exists-check with full fetch on update so existing unmanaged attributes (remarks, admin-c, tech-c, etc.) are preserved in PUT/update payloads - Add delete_route() to RIPE, ARIN, and RADb clients - Mirror every RIPE and ARIN route change (create/update/delete) to RADb automatically when a radb section is present in the config - Skip RADb-only routes that were already mirrored to avoid double-syncing - Document delete:true flag, automatic mirroring, and attribute preservation in README
Public repo in one of Mozilla’s GH Orgs should include their Code of Conduct file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{code:diff}block with+/-/remarks,admin-c,tech-c, etc.) are preserved when updating route objects in RIPE, ARIN, and RADb — only managed fields are overwrittenradbsection is present in the config, every RIPE and ARIN route change (create, update, or delete) cascades to RADb automatically; explicit RADb routes that were already mirrored are skippeddelete: truesupport for RIPE: Route objects can now be declaratively deleted from RIPE (ARIN already supported this); deletions mirror to RADb when mirroring is configureddelete_route()added to all three clients (RIPE, ARIN, RADb)CODE_OF_CONDUCT.mdper Mozilla open-source requirementsTest plan
uv run pytest)uv run ruff check .)