Bugfix FXIOS-11809 [Blueprint Download Manager] Avoid automatic throttling of live activity updates #26134
+27
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 34.91
Generated by 🚫 Danger Swift against 737a0c9 |
Cramsden
reviewed
Apr 17, 2025
Comment on lines
54
to
74
| Task { | ||
| await downloadLiveActivity?.end(using: contentState, | ||
| dismissalPolicy: .after(.now.addingTimeInterval(durationToDismissal.rawValue))) | ||
| if !throttle || shouldUpdateLiveActivity() { | ||
| Task { | ||
| await self.downloadLiveActivity?.update(using: contentState) | ||
| } |
There was a problem hiding this comment.
Hi @DanielDervishi! In an attempt to try to make our concurrency as structured as possible could we make this update async and then have the callers create the tasks? Then we wouldn't need to spin up two separate tasks for updating and for ending the activity?
We really only want to create a new task (unstructured concurrency) when we don't care when the work finishes (fire and forget) Update feels like something we want to wait to finish right?
There was a problem hiding this comment.
Sure thing, thanks Carson!
… from happening automatically
DanielDervishi
force-pushed
the
DD/11809-less-updates-download-live-activities
branch
from
737a0c9 to
42d7ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)