Bugix [Content Sharing opt] fix home page activity and File copy to clipboard message #26167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 35.01
Generated by 🚫 Danger Swift against f5bc62c |
lmarceau
reviewed
Apr 17, 2025
|
|
||
| private func createSubject(url: URL? = nil, | ||
| title: String? = nil) -> HomePageActivity { | ||
| return HomePageActivity(url: url, title: title) |
There was a problem hiding this comment.
trackForMemoryLeaks maybe? Since HomePageActivity is a class
lmarceau
approved these changes
Apr 23, 2025
clarmso
pushed a commit
that referenced
this pull request
Apr 24, 2025
…lipboard message (#26167) * Fix home page activity and add correct label when copying pdf to clipboard * Fixed tests and removed unused import --------- Co-authored-by: Filippo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
File copied to clipboard
Jira ticket
Github issue
Home page activity with localhost when reader mode active
Jira ticket
Github issue
💡 Description
Bugfix
Home page activityshowing localhost when sharing a tab in reader mode. Add correct label when copying a pdf to clipboard.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)