Refactor FXIOS-11799 [Profile] Decouple SearchEnginesManager from Profile #26203
+174
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antigluten
changed the title
FilippoZazzeroni
requested changes
Apr 24, 2025
There was a problem hiding this comment.
Great work @antigluten just few small nits. thanks for your contribution 😃
firefox-ios/Client/Frontend/Settings/SettingsTableViewController.swift
Outdated
Show resolved
Hide resolved
firefox-ios/Client/Frontend/Settings/CustomSearchViewController.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/Toolbar/AddressToolbarContainerModelTests.swift
Show resolved
Hide resolved
FilippoZazzeroni
approved these changes
Apr 24, 2025
|
@FilippoZazzeroni, I've fixed some test, could you review them, please? Also, is it okay to leave registering dependencies at that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Decoupled
SearchEnginesManagerfrom Profile📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)