Remove FXIOS-11952 ⁃ Remove jump back in feature flag #26225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 34.91
Generated by 🚫 Danger Swift against c9c07bd |
lmarceau
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
One nit, otherwise LGTM! We should put this ticket in QA needed and let them know they should test the use case where they have a prefs already for jump back in. Upgrading to this version they should have the same pref enabled (i.e. if jump back in was disabled, it should stay disabled).
| actionType: JumpBackInActionType.toggleShowSectionSetting | ||
| ) | ||
| ) | ||
| } | ||
| sectionItems.append(jumpBackInSetting) | ||
| } | ||
|
|
There was a problem hiding this comment.
We have another if let profile { on the line below, we could combine both jumpBackInSetting and bookmarksSetting in the same if so we only unwrap the profile once?
…k_in_flag # Conflicts: # firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift
dicarobinho
deleted the
afarcasanu/fxios_11952_25998_remove_jump_back_in_flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Removed JumpBackIn feature flag
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)