Bugfix FXIOS-11784 Fixed Pass book rendering hang #26230
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Open pass method logic with async/await and moved presenter logic to main actor.
Foxbolts
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Hey @jayantpatil - thank you for the contribution! Looks good 🚀
Client.app: Coverage: 34.88
Generated by 🚫 Danger Swift against fa03606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Open pass method logic with async/await to prevent hang and moved presenter logic to main actor.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)